Fix makefile build #268
Merged
Fix makefile build #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moti Asayag <[email protected]> rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Moti Asayag <[email protected]> rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
masayag
force-pushed
the
fix-makefile-build
branch
from
b831028 to
3b7722e
Compare
Signed-off-by: Moti Asayag <[email protected]> rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
masayag
force-pushed
the
fix-makefile-build
branch
from
3b7722e to
5b1d5bf
Compare
masayag
commented
Jun 23, 2024
| @@ -9,7 +9,7 @@ fi | |||
|
|
|||
| if [ ! -f kn ]; then | |||
| echo "Installing kn-workflow CLI" | |||
| KN_CLI_URL="https://mirror.openshift.com/pub/openshift-v4/clients/serverless/latest/kn-linux-amd64.tar.gz" | |||
| KN_CLI_URL="https://mirror.openshift.com/pub/openshift-v4/clients/serverless/1.11.2/kn-linux-amd64.tar.gz" | |||
There was a problem hiding this comment.
@gabriel-farache pls note this one had to be updated as well.
There was a problem hiding this comment.
We are duplicating the same piece of code in so many places x))
There was a problem hiding this comment.
"too many"...only in 3 different places :-P
but yes, we can invoke a script from the github action, used by the same makefile and reduce one copy.
next, we can evaluate if the pipeline can be modified to use the exact script.
There was a problem hiding this comment.
only in 3 different places :-P
Yes but not even in the same repo :)
rgolangh
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Jun 23, 2024
rgolangh
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Jun 23, 2024
rgolangh
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Jun 23, 2024
rgolangh
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Jun 23, 2024
rgolangh
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Jun 23, 2024
rgolangh
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.